Feature implemented from feature request #82 (#83) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: initial commit from an ad-hoc fix * feat: seperate list and single value assignment * feat: assign_json_path_values method parameter changed * feat: function parameter change * feat: lint util.py * feat: comments added * fix: remove unused print * feat: Collect array info from jspath * fix: change condition when assign_json_path_values is invoked * feat: assign_json_path_values further implemented * feat: further implemented assign_json_path_value * feat: assign_json_path_values further implemented * feat: assign_json_path_values further implemented * feat: assign_json_path_values cleaned * feat: assign_json_path_values cleaned * feat: assign_json_path_values cleaned * feat: assign_json_path_values cleaned * feat: more comments added * feat: more comments added * feat: more comments added * fix: bug fix * feat: Update implemented in assign_json_path_values * feat: code cleaning * feat: method parameter changes * feat: black util.py * feat: clean up Split source and destination jsonpath by their array components * feat: clean up Split source and destination jsonpath by their array components * feat: further code minor cleaning * feat: further code minor cleaning * feat: further code minor cleaning * feat: further code cleaning * feat: further code cleaning * doc: method comments added * fix: lint the code * test: jsonpath_array test added * fix: +jsonpath-ng upgraded to 1.5.3 * test: fix test cases for array mapping * test: test case polished * doc: comments polished * doc: lint --------- Co-authored-by: Hailiang Zhang <[email protected]> Co-authored-by: Jonathan Kovarik <[email protected]> Co-authored-by: etcart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request implemented CMA feature request #82 (CMA output name changes for an array).
The current PR should only add the new feature and should not affect any other existing implementation.
It does introduce a tree structure for source->destination array mapping, which is documented in the detail in the source code, but please let me know if it's not straightforward to follow and I will be happy to have a walkthrough.
Notes:
Testing has been added and validated with #81.
There are 2 pylint warnings:
message_adapter/util.py:36:0: R0903: Too few public methods (1/2) (too-few-public-methods)
message_adapter/util.py:81:0: R0914: Too many local variables (20/15) (too-many-locals)
I am a little bit reluctant to adapt my code regardingly, and not sure we can ignore them or not, but please let me know if it causes issue for CICD.
Thanks!