GETD check remaining buffer size before adding data #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses #226
It adds a check to
MessageHandlers::HandleGetD
, ensuring no data will be added to the response buffer if the remaining space in the buffer is not sufficient to accept the data. As described in #226, this can lead to a segmentation fault, resulting in a CTD of X-Plane itself.Consequences:
The current fix leaves the request unanswered (no message being sent), so the connection will time out on client side.
Alternate Solutions:
break
instead ofreturn
in line 547).Advantages of alternate solutions
Client receives at least some data (1) or clear information why the request failed (2)
Disadvantages of alternate solutions
Requires modification of all client libraries to
Conclusion
The current fix is not perfect, but prevents the simulator from crashing, and doesn't require modification of the client libraries.