Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dtypes to stable api #1087

Merged
merged 40 commits into from
Sep 29, 2024

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Sep 28, 2024

This is quite a refactor, and takes some effort

but I think it's worth it, I think having a solid stable api mechanism will prove to be important


this is becoming too complicated and cumbersome, I think dtypes needs to be passed when initialising the Series objects in from_native, then they can just use self._dtypes instead of passing around the module..

@github-actions github-actions bot added the enhancement New feature or request label Sep 28, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review September 29, 2024 20:21
@MarcoGorelli MarcoGorelli merged commit e3d2a4b into narwhals-dev:main Sep 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant