feat: add DataFrame|LazyFrame.unpivot method
#1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Sep 22, 2024
FBruzzesi
commented
Sep 22, 2024
Comment on lines
+645
to
+659
| return self._from_native_frame( | ||
| pa.concat_tables( | ||
| [ | ||
| pa.Table.from_arrays( | ||
| [ | ||
| *[native_frame.column(idx_col) for idx_col in index_], | ||
| pa.array([on_col] * n_rows, pa.string()), | ||
| native_frame.column(on_col), | ||
| ], | ||
| names=[*index_, variable_name, value_name], | ||
| ) | ||
| for on_col in on_ | ||
| ] | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Adapted from the following StackOverflow Answer
FBruzzesi
commented
Sep 22, 2024
Comment on lines
+743
to
+744
| var_name=variable_name if variable_name is not None else "variable", | ||
| value_name=value_name if value_name is not None else "value", |
There was a problem hiding this comment.
That's because passing None (from the default of narwhals DataFrame) will overwrite the pandas default value of "value"
FBruzzesi
changed the title
DataFrame|LazyFrame.unpivot for all backends
FBruzzesi
changed the title
DataFrame|LazyFrame.unpivot for all backendsDataFrame|LazyFrame.unpivot method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Plotly will most likely need this feature if they decide to use narwhals
Checklist
If you have comments or can explain your changes, please do so below.