Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyData Sphinx Theme pin #161

Merged
merged 7 commits into from
May 30, 2024
Merged

Remove PyData Sphinx Theme pin #161

merged 7 commits into from
May 30, 2024

Conversation

melissawm
Copy link
Member

Includes fixes for the primary sidebar compatible with PST 0.15.3

Includes fixes for the primary sidebar compatible with PST 0.15.3
psobolewskiPhD and others added 3 commits May 28, 2024 18:44
* use setuptools_scm for versioning

* ensure checkout depth is correctly set

* remove problematic [tool.setuptools.dynamic]
@melissawm melissawm marked this pull request as ready for review May 28, 2024 21:45
@melissawm
Copy link
Member Author

That did not fix the nav bar decoration 😢 I'll come back to this tomorrow.

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented May 29, 2024

I re-ran CI since 15.3 has been released.
Looking at the artifact:

image - left-hand-size ToC is missing: image

@melissawm
Copy link
Member Author

Not sure what happened to the toc, but a lot has been merged in the past few days over at PST. For the other items - that's what I was trying to fix in my last commit. I'll take a look tomorrow.

@melissawm
Copy link
Member Author

I think I got it, but we'll also need to update the docs, see napari/docs#423

@psobolewskiPhD
Copy link
Member

The nav bar looks fixed!
You rock!
image

@melissawm
Copy link
Member Author

With the latest commit to napari-docs this should be complete, including disabling the back-to-top button @jni

Let me know if you see any other glaring issues before we upgrade

@psobolewskiPhD
Copy link
Member

I'd be ok with optimistically merging and releasing and then we see how it builds over there.
Worst case there is some glitch in dev docs?

@melissawm
Copy link
Member Author

There shouldn't be, but I'll be available to fix this weekend if that happens.

@psobolewskiPhD
Copy link
Member

I have the Pacific meeting with Juan (and hopefully others!) this evening, so I'll bring this up then and maybe we can get it merged and released.
If we're really concerned we could release without this (because a few small fixes were merged) and then merge and release this in it's own release?

@melissawm
Copy link
Member Author

Thats up to you, I don't necessarily see an advantage in releasing without this PR

@jni jni merged commit 149c5a5 into napari:main May 30, 2024
1 check passed
@jni
Copy link
Member

jni commented May 30, 2024

That's what I think. 😜

jni added a commit to napari/docs that referenced this pull request Jun 1, 2024
# References and relevant issues
Depends on napari/napari-sphinx-theme#161

(and a new release of the theme)

# Description
Restores the sidebar after the PyData Sphinx Theme is updated to version
0.15.3

---------

Co-authored-by: Juan Nunez-Iglesias <[email protected]>
Co-authored-by: Peter Sobolewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants