-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed completion scripts in binary #165
Conversation
Seems to work. Need to check on the lint failures.
|
We may need to adjust how these lints work? I've added some |
Our completion scripts can be embedded as global strings. New zsh-completion and bash-completion subcommands print these embedded strings to stdout. Users can source them from their startup scripts: source <(dstask zsh-completion) Add symlinks at original completion script locations to (hopefully) ease transition for packagers. Remove these eventually. Also, update CI test env to golang:1.16
This is ready for review. I've opted to add |
@naggie bump |
Thanks @dontlaugh -- a useful change. I like the new mechanism to loading strings into the exe provided by go! Sorry it took so long to merge. |
Our completion scripts can be embedded as global strings.
New zsh-completion and bash-completion subcommands print these embedded
strings to stdout. Users can source them from their startup scripts:
Add symlinks at original completion script locations to (hopefully) ease
transition for packagers. Remove these eventually.
Also, update CI test env to golang:1.16
Closes #162