Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNORE UPPERCASE OPENSTACK TOO FOR FUCKS SAKE #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IGNORE UPPERCASE OPENSTACK TOO FOR FUCKS SAKE #5

wants to merge 1 commit into from

Conversation

tomassedovic
Copy link
Contributor

OBVIOUSLY you don't want jstir bothering you every time you mention an OPENSTACK_* environment variable. Jesus.

OBVIOUSLY you don't want jstir bothering you every time you mention an `OPENSTACK_*` environment variable. Jesus.
@infraredgirl
Copy link

You are missing a comma after "TOO" in the commit message. Also "FUCKS" should be "FUCK'S". Otherwise LGTM.

@n1zyy
Copy link
Owner

n1zyy commented Sep 24, 2014

If you're trying to not trigger on OPENSTACK_* then OBVIOUSLY you should just change the regex to match THAT, not "OPENSTACK" with no underscore like some computer illiterate. 🐪

Alternatively, if you are prone to RANDOM ALL-CAPS OUTBURSTS ABOUT OPENSTACK (and honestly, who isn't?), I think this is 👍, though I agree with @infraredgirl on needing an apostrophe on FUCKS.

@jsomara
Copy link

jsomara commented Sep 24, 2014

💩
💩
💩
💩
💩
💩
💩
💩

@jdob
Copy link

jdob commented Sep 24, 2014

I concur with jsomara.

@jistr
Copy link

jistr commented Sep 24, 2014

/me subscribes to notifications from this PR 🐨

@jistr
Copy link

jistr commented Sep 24, 2014

I googled the emojis and made you folks a

steeplechase diorama

🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎

🏇     🚴         🐎 🏃        🐩

@trixytrix
Copy link

-1

I do want jstir bother me every time someone mentions an OPENSTACK_* environment variable. Jesus.

@n1zyy
Copy link
Owner

n1zyy commented Sep 24, 2014

You are my hero, @jistr 👏

@jsomara
Copy link

jsomara commented Sep 24, 2014

☁️ ☁️ ☁️☁️
🚁
🌲 🌲 🌲 🌲 🌲 🌲 🌲
🌲 🌲 🌲 🌲 / \ 🌲 🌲 🌲
🌲 🔥 🔥 / \ 🌲 🌲 🌲
🔥 🔥 🔥 / 🚔 🚔 \ 🌲 🌲
🌲 🌲 / :oncoming_police_car: 🚔 \ 🌲 🌲
🌲 🌲 / 🚘 \ 🌲 🌲

@d0ugal
Copy link

d0ugal commented Sep 24, 2014

-1 this doesn't pass PEP8

@jistr
Copy link

jistr commented Sep 24, 2014

@jsomara awesoooome 😍

@n1zyy
Copy link
Owner

n1zyy commented Sep 24, 2014

Only you can prevent forest fires, @jsomara 🐻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants