refactor(iroh-net): Debug logging should not be per packet set #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are logged for each packet on the relay path. That's not what we do on debug logging. One case is already covered by other trace logging, so just move the "why", the other case can be a trace log.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2818/docs/iroh/ Last updated: 2024-10-18T15:49:00Z |
dignifiedquire
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are logged for each packet on the relay path. That's not what
we do on debug logging. One case is already covered by other trace
logging, so just move the "why", the other case can be a trace log.
Breaking Changes
None
Notes & open questions
Change checklist