Merge pull request #984 from hazendaz/tests

More test cleanup
mybatis · Aug 11, 2024 · fb4d3db · fb4d3db
2 parents 0f9528f + b625cae
commit fb4d3db
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/src/test/java/org/mybatis/spring/asyncsynchronization/AsyncAfterCompletionHelper.java b/src/test/java/org/mybatis/spring/asyncsynchronization/AsyncAfterCompletionHelper.java
@@ -66,9 +66,8 @@ public Object invoke(final Object proxy, final Method method, final Object[] arg
       thread.join();
       if (exceptionSet.isEmpty()) {
         return retValSet.iterator().next();
-      } else {
-        throw exceptionSet.iterator().next();
       }
+      throw exceptionSet.iterator().next();
     }
 
   }

diff --git a/src/test/java/org/mybatis/spring/batch/MyBatisCursorItemReaderTest.java b/src/test/java/org/mybatis/spring/batch/MyBatisCursorItemReaderTest.java
@@ -90,12 +90,17 @@ private List<Object> getFoos() {
     return Arrays.asList(new Foo("foo1"), new Foo("foo2"), new Foo("foo3"));
   }
 
+  // Note: Do not cleanup this 'foo' class
   private static class Foo {
     private final String name;
 
     Foo(String name) {
       this.name = name;
     }
+
+    public String getName() {
+      return this.name;
+    }
   }
 
 }
diff --git a/src/test/java/org/mybatis/spring/batch/builder/MyBatisBatchItemWriterBuilderTest.java b/src/test/java/org/mybatis/spring/batch/builder/MyBatisBatchItemWriterBuilderTest.java
@@ -176,12 +176,17 @@ private Chunk<Foo> getFoos() {
     return Chunk.of(new Foo("foo1"), new Foo("foo2"), new Foo("foo3"));
   }
 
+  // Note: Do not cleanup this 'foo' class
   private static class Foo {
     private final String name;
 
     Foo(String name) {
       this.name = name;
     }
+
+    public String getName() {
+      return this.name;
+    }
   }
 
 }
diff --git a/src/test/java/org/mybatis/spring/submitted/xa/UserServiceImpl.java b/src/test/java/org/mybatis/spring/submitted/xa/UserServiceImpl.java
@@ -44,7 +44,7 @@ public void saveWithFailure(User user) {
 
   @Override
   public boolean checkUserExists(int id) {
-    if ((userMapperMaster.select(id) != null) || (userMapperSlave.select(id) != null)) {
+    if (userMapperMaster.select(id) != null || userMapperSlave.select(id) != null) {
       return true;
     }
     return false;