-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use target-prefixed executables when cross-compiling #36
base: master
Are you sure you want to change the base?
Conversation
Also allow the executable prefix or path to be overridden by the environment.
@Skirmisher This bug is now fixed in v0.1.13 of my fork |
@BenjaminRi Thanks for letting me know! However, the commits on your fork have lost the authorship info from other contributors (e.g. myself and @Nilstrieb). Could you please fix this (preferably by rebasing appropriately) and force-update your repo? I can provide assistance if necessary. |
@Skirmisher You are correct in that they lost their authorship. I didn't fork the |
@BenjaminRi Whether or not you used GitHub's "fork" button doesn't matter—rebasing or merging commits between branches, whether they belong to the same repo or different ones, is just part of the standard git workflow. I appreciate your intention; however, you should be preserving commits as a general rule, including contributor authorship (regardless of how many lines they are responsible for), unless the authors have indicated otherwise. Failure to do so is very disrespectful, makes it more difficult to understand the code's history in the future, and can even present legal issues; not to mention that copying changes around outside of a git context is error-prone. If you intend for your fork to be the new "source of truth" for an unmaintained project, then it is especially good practice to keep its commit history as clean as possible, for the sake of longevity and posterity. To merge others' changes into your fork, start with the original
This will add the other fork as a remote to your local repository, and then fetch the branch with the commits you want right afterward. Then, just run
to immediately make a merge commit pulling in the remote branch's changes (after editing the merge commit's message). If you want to edit the changes, run |
@Skirmisher I'll look into it when I have time. I primarily care about the function of the crate, and this is what I will prioritize. However, I do recognize that organizational details can matter as well. |
@Skirmisher I put it right and added your original commit into the history, as you asked (BenjaminRi/winresource@44068cf). Your name will forever be embedded in my humble fork, granting you negligible amounts of fame and recognition. I hope I now corrected my mistake to your satisfaction. Thank you for your contribution, I appreciate it. |
This adds some logic to determine if cross-compilation is occurring, and picks the right prefix to use depending on the target, similar to what the
cc
crate does. It also reads the environment to allow the executable to be overridden by the user, rather than just the library author.I removed the conditional
.exe
suffix to make things simpler, since Windows doesn't need it when running from PATH.