Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppressHydrationWarning bug #992

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Sep 27, 2024

this was being converted to an attribute and had no effect 😅

@luwes luwes self-assigned this Sep 27, 2024
@luwes luwes requested review from heff and a team as code owners September 27, 2024 16:21
Copy link

vercel bot commented Sep 27, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 4:22pm

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (3ea80df) to head (68beb46).
Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   78.55%   76.89%   -1.67%     
==========================================
  Files          59       50       -9     
  Lines       11080    12088    +1008     
  Branches        0      695     +695     
==========================================
+ Hits         8704     9295     +591     
- Misses       2376     2768     +392     
- Partials        0       25      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@luwes luwes merged commit 2d392f2 into muxinc:main Sep 27, 2024
5 of 8 checks passed
@luwes luwes deleted the fix-suppresshydrationwarning branch September 27, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants