fix: restructure menu header for styling #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
==========================================
- Coverage 78.55% 76.89% -1.67%
==========================================
Files 59 50 -9
Lines 11080 12088 +1008
Branches 0 695 +695
==========================================
+ Hits 8704 9295 +591
- Misses 2376 2768 +392
- Partials 0 25 +25 ☔ View full report in Codecov by Sentry. |
luwes
force-pushed
the
menu-header-css
branch
from
11c3956
to
9f97445
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
changed the title
luwes
force-pushed
the
menu-header-css
branch
from
9f97445
to
3281fd6
Compare
luwes
force-pushed
the
menu-header-css
branch
from
d74f1b0
to
29119ea
Compare
luwes
force-pushed
the
menu-header-css
branch
from
29119ea
to
67003a8
Compare
luwes
commented
Sep 26, 2024
| } | ||
|
|
||
| slot[name="header"] > *, | ||
| slot[name="header"]::slotted(*) { |
There was a problem hiding this comment.
by setting it on the default or slotted elements the styles can be easily overridden
luwes
commented
Sep 26, 2024
| @@ -729,7 +733,7 @@ class MediaChromeMenu extends globalThis.HTMLElement { | |||
| return headerSlot | |||
| .assignedElements({ flatten: true }) | |||
| ?.find( | |||
| (el) => el.part.contains('back') && el.part.contains('button') | |||
| (el) => el.matches('button[part~="back"]') | |||
There was a problem hiding this comment.
keep consistent with CSS selector (cursor pointer) above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #987