fix: tooltip type error #988
Conversation
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
| } | ||
|
|
||
| this.tooltipEl = this.shadowRoot.querySelector('media-tooltip'); |
There was a problem hiding this comment.
we still want to get the media-tooltip if the shadow dom was SSR'd
There was a problem hiding this comment.
question(non-blocking): given the error, should we just move tooltipEl to a getter that lazy evals this.shadowRoot.querySelector('media-tooltip');?
| this.removeEventListener('click', this.#clickListener); | ||
| this.tooltipEl = null; |
There was a problem hiding this comment.
on disconnected we don't want to empty this property because we only query it in the constructor, not in connectedCallback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
- Coverage 78.55% 76.89% -1.67%
==========================================
Files 59 50 -9
Lines 11080 12088 +1008
Branches 0 695 +695
==========================================
+ Hits 8704 9295 +591
- Misses 2376 2768 +392
- Partials 0 25 +25 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| this.tooltipEl = this.shadowRoot.querySelector('media-tooltip'); |
There was a problem hiding this comment.
question(non-blocking): given the error, should we just move tooltipEl to a getter that lazy evals this.shadowRoot.querySelector('media-tooltip');?
|
good idea. for now it's fine I think because we don't reset it anymore. we cache it right after the DOM is appended so the query will always return the media-tooltip element. |
luwes
force-pushed
the
fix-tooltip-typeerror
branch
from
aea5b42
to
93324bd
Compare
fix #986