Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sticky chapter on mouseout #1005

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/js/media-chrome-range.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { MediaStateReceiverAttributes } from './constants.js';
import { globalThis, document } from './utils/server-safe-globals.js';
import {
insertCSSRule,
getOrInsertCSSRule,
getPointProgressOnLine,
} from './utils/element-utils.js';
Expand Down Expand Up @@ -388,6 +387,10 @@ class MediaChromeRange extends globalThis.HTMLElement {
this.#cssRules.pointer = getOrInsertCSSRule(this.shadowRoot, '#pointer');
this.#cssRules.progress = getOrInsertCSSRule(this.shadowRoot, '#progress');
this.#cssRules.thumb = getOrInsertCSSRule(this.shadowRoot, '#thumb');
this.#cssRules.activeSegment = getOrInsertCSSRule(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMRT.

this.shadowRoot,
'#segments-clipping rect:nth-child(0)'
);

const mediaControllerId = this.getAttribute(
MediaStateReceiverAttributes.MEDIA_CONTROLLER
Expand Down Expand Up @@ -448,11 +451,6 @@ class MediaChromeRange extends globalThis.HTMLElement {

if (!segments?.length) return;

this.#cssRules.activeSegment = insertCSSRule(
this.shadowRoot,
'#segments-clipping rect:nth-child(0)'
);

const normalized = [
...new Set([
+this.range.min,
Expand Down