fix: remove unneeded shims, setTimeout is support

ed everywhere
muxinc · Jul 13, 2023 · e6a61b6 · e6a61b6
1 parent 610d490
commit e6a61b6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 17 deletions.
diff --git a/src/js/experimental/media-chrome-listbox.js b/src/js/experimental/media-chrome-listbox.js
@@ -419,10 +419,10 @@ class MediaChromeListbox extends globalThis.HTMLElement {
   }
 
   #clearKeysOnDelay() {
-    globalThis.clearTimeout(this.#clearKeysTimeout);
+    clearTimeout(this.#clearKeysTimeout);
     this.#clearKeysTimeout = null;
 
-    this.#clearKeysTimeout = globalThis.setTimeout(() => {
+    this.#clearKeysTimeout = setTimeout(() => {
       this.#keysSoFar = '';
       this.#clearKeysTimeout = null;
     }, 500);

diff --git a/src/js/media-container.js b/src/js/media-container.js
@@ -317,7 +317,7 @@ class MediaContainer extends globalThis.HTMLElement {
       if (pendingResizeCb) return;
       // Just in case it takes too long (which will cause an error to throw),
       // do the breakpoint computation asynchronously
-      globalThis.setTimeout(() => {
+      setTimeout(() => {
         resizeCallback(entries);
         // Once we've completed, reset the pending cb flag to false
         pendingResizeCb = false;
@@ -481,12 +481,12 @@ class MediaContainer extends globalThis.HTMLElement {
     const scheduleInactive = () => {
       setActive();
 
-      globalThis.clearTimeout(this._inactiveTimeout);
+      clearTimeout(this._inactiveTimeout);
 
       // Setting autohide to -1 turns off autohide
       if (this.autohide < 0) return;
 
-      this._inactiveTimeout = globalThis.setTimeout(() => {
+      this._inactiveTimeout = setTimeout(() => {
         setInactive();
       }, this.autohide * 1000);
     };
@@ -527,7 +527,7 @@ class MediaContainer extends globalThis.HTMLElement {
 
       setActive();
       // Stay visible if hovered over control bar
-      globalThis.clearTimeout(this._inactiveTimeout);
+      clearTimeout(this._inactiveTimeout);
 
       // If hovering over something other than controls, we're free to make inactive
       // @ts-ignore

diff --git a/src/js/utils/server-safe-globals.js b/src/js/utils/server-safe-globals.js
@@ -30,13 +30,6 @@ const globalThisShim = {
   },
   CustomEvent: function CustomEvent() {},
   getComputedStyle: function () {},
-  // eslint-disable-next-line no-unused-vars
-  requestAnimationFrame: function(_cb) {
-    return 1;
-  },
-  // eslint-disable-next-line no-unused-vars
-  queueMicrotask: function(_cb) {
-  },
 };
 
 export const isServer =
@@ -60,17 +53,13 @@ const isShimmed = Object.keys(globalThisShim)
   * getComputedStyle,
   * addEventListener?,
   * removeEventListener?,
-  * setTimeout?,
-  * clearTimeout?,
   * localStorage?,
   * WebKitPlaybackTargetAvailabilityEvent?,
   * window?,
   * document?,
   * chrome?,
   * DocumentFragment?,
   * ResizeObserver?,
-  * requestAnimationFrame,
-  * queueMicrotask,
   * CastableVideoElement?
   * } }
   * */