Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set block_when_disconnected to false on android #6990

Merged

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Oct 16, 2024


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Oct 16, 2024
@Pururun Pururun requested review from Rawa and hulthe October 16, 2024 09:11
Copy link

linear bot commented Oct 16, 2024

@Pururun Pururun force-pushed the always-set-lockdown-mode-to-false-on-android-droid-1445 branch from d95fcae to 580bda6 Compare October 16, 2024 09:12
@Pururun Pururun removed the request for review from hulthe October 16, 2024 09:13
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

albin-mullvad
albin-mullvad previously approved these changes Oct 16, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be good if someone from the desktop team also approves this change

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the always-set-lockdown-mode-to-false-on-android-droid-1445 branch 3 times, most recently from 6ad7711 to 54702df Compare October 16, 2024 09:38
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


mullvad-daemon/src/settings/mod.rs line 182 at r3 (raw file):

                if cfg!(not(target_os = "android")) {
                    settings.block_when_disconnected = true;
                }

👍

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest clarifying in the PR and commit that it's the daemon lockdown so that anyone else reading this doesn't confuse it for the Android OS lockdown mode.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun changed the title Always set lockdown mode to false on android Always set block_when_disconnected to false on android Oct 16, 2024
@Pururun Pururun force-pushed the always-set-lockdown-mode-to-false-on-android-droid-1445 branch from 54702df to 956628c Compare October 16, 2024 10:41
@Pururun Pururun requested a review from Serock3 October 16, 2024 10:43
@albin-mullvad albin-mullvad force-pushed the always-set-lockdown-mode-to-false-on-android-droid-1445 branch from 956628c to 0c655dc Compare October 16, 2024 13:01
@albin-mullvad albin-mullvad merged commit 439b08d into main Oct 16, 2024
49 checks passed
@albin-mullvad albin-mullvad deleted the always-set-lockdown-mode-to-false-on-android-droid-1445 branch October 16, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants