-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set block_when_disconnected to false on android #6990
Always set block_when_disconnected to false on android #6990
Conversation
d95fcae
to
580bda6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would probably be good if someone from the desktop team also approves this change
Reviewable status: complete! all files reviewed, all discussions resolved
6ad7711
to
54702df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
mullvad-daemon/src/settings/mod.rs
line 182 at r3 (raw file):
if cfg!(not(target_os = "android")) { settings.block_when_disconnected = true; }
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest clarifying in the PR and commit that it's the daemon lockdown so that anyone else reading this doesn't confuse it for the Android OS lockdown mode.
Reviewable status: complete! all files reviewed, all discussions resolved
54702df
to
956628c
Compare
956628c
to
0c655dc
Compare
This change is