Export artifacts into xcresult #6980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojganii
force-pushed
the
convert-junit-output-artifacts-to-xcresult-ios-870
branch
4 times, most recently
from
3f425e7
to
743ca78
Compare
buggmagnet
requested changes
Oct 15, 2024
There was a problem hiding this comment.
I'm a bit confused, how is changing just the filename turning those junit.xml files into xcresult files ?
Am I missing something here ?
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mojganii)
.github/workflows/ios-end-to-end-tests-settings-migration.yml line 116 at r2 (raw file):
test_device_identifier_uuid: ${{ secrets.IOS_TEST_DEVICE_IDENTIFIER_UUID }} has_time_account_number: ${{ secrets.IOS_HAS_TIME_ACCOUNT_NUMBER_PRODUCTION }} no_time_aÏccount_number: ${{ secrets.IOS_NO_TIME_ACCOUNT_NUMBER_PRODUCTION }}
It looks like this was introduced by mistake, please revert this
mojganii
force-pushed
the
convert-junit-output-artifacts-to-xcresult-ios-870
branch
9 times, most recently
from
941ec21
to
7ef9375
Compare
mojganii
force-pushed
the
convert-junit-output-artifacts-to-xcresult-ios-870
branch
from
7ef9375
to
51a902e
Compare
mojganii
force-pushed
the
convert-junit-output-artifacts-to-xcresult-ios-870
branch
from
923f7ab
to
d6e69a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality to export build artifacts in the
xcresultformat. By exporting test results inxcresult, we can take advantage of Xcode’s powerful tools for analyzing test outcomes and improving our testing workflows.This change is