Clean up build warning #6967
Merged
Clean up build warning #6967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawa
force-pushed
the
clean-up-build-warning-droid-1394
branch
from
6bb08f3
to
ec9f685
Compare
Rawa
commented
Oct 11, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved
android/app/src/debug/AndroidManifest.xml line 8 at r1 (raw file):
tools:ignore="ScopedStorage" /> <!-- Permission for 30 and below --> <uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE"
As I understand it the external permissions is used to take screenshots for failed e2e tests, we need to very this actually works.
Pururun
previously approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Rawa
force-pushed
the
clean-up-build-warning-droid-1394
branch
from
ec9f685
to
104e241
Compare
kl
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Rawa
force-pushed
the
clean-up-build-warning-droid-1394
branch
from
f80bcbf
to
cfa0147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is