Fix re-subscribe crash #6948
Fix re-subscribe crash #6948
Conversation
There was a problem hiding this comment.
Looks good. Please add a changelog item as well 🙏
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Added!
Reviewable status: 1 of 2 files reviewed, all discussions resolved
Rawa
force-pushed
the
crash-in-customlistlocationsscreen-droid-1406
branch
from
7d87e6a
to
425fec3
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/CHANGELOG.md line 41 at r2 (raw file):
- Fix VPN service being recreated multiple times when toggling certain options. - Fix unlabeled icon buttons for basic accessibility with screen readers. - Fix crash when edit custom list locations screen and changing app langauge.
typo? Should probably be "...when in the edit custom list locations screen..."
Code quote:
Fix crash when edit custom list locations screen and changing app langauge.
Rawa
force-pushed
the
crash-in-customlistlocationsscreen-droid-1406
branch
from
425fec3
to
97854c1
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Rawa
force-pushed
the
crash-in-customlistlocationsscreen-droid-1406
branch
from
97854c1
to
871255d
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
This change is