Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end to end connection tests for multihop ios 778 #6914

Merged

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Oct 3, 2024

This PR adds an end-to-end test for Multihop and fixes minor issues, such as the shrinking of the collapse button in the connection view. Additionally, after changing the data type for the collapse view, we forgot to update the UI tests to ensure compatibility in finding elements.


This change is Reviewable

Copy link

linear bot commented Oct 3, 2024

@mojganii mojganii self-assigned this Oct 3, 2024
@mojganii mojganii added the iOS Issues related to iOS label Oct 3, 2024
@mojganii mojganii force-pushed the add-end-to-end-connection-tests-for-multihop-ios-778 branch from 15205fd to 9f670e0 Compare October 3, 2024 14:13
Copy link
Collaborator

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 8 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mojganii mojganii force-pushed the add-end-to-end-connection-tests-for-multihop-ios-778 branch 5 times, most recently from dd4fcd2 to ed5b710 Compare October 4, 2024 14:50
rablador
rablador previously approved these changes Oct 7, 2024
Copy link
Collaborator

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/MullvadVPNUITests/RelayTests.swift line 269 at r4 (raw file):

        VPNSettingsPage(app)
            .tapMultihopSwitch()
            .swipeDownToDismissModal()

Interestingly enough, if I run this code on an iPhone SE, it doesn't dismiss the settings.
I think we should replace this by tapping the back, and done buttons respectively instead.

@mojganii mojganii force-pushed the add-end-to-end-connection-tests-for-multihop-ios-778 branch from ed5b710 to 825b278 Compare October 7, 2024 15:18
Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @buggmagnet and @rablador)


ios/MullvadVPNUITests/RelayTests.swift line 269 at r4 (raw file):

Previously, buggmagnet wrote…

Interestingly enough, if I run this code on an iPhone SE, it doesn't dismiss the settings.
I think we should replace this by tapping the back, and done buttons respectively instead.

Done.

Copy link
Collaborator

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 7 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the add-end-to-end-connection-tests-for-multihop-ios-778 branch from 825b278 to 8b1e180 Compare October 8, 2024 14:12
@buggmagnet buggmagnet merged commit b54a6c3 into main Oct 8, 2024
10 of 11 checks passed
@buggmagnet buggmagnet deleted the add-end-to-end-connection-tests-for-multihop-ios-778 branch October 8, 2024 14:15
Copy link

github-actions bot commented Oct 8, 2024

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants