Separate ICMP reads from writes #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
previously approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
pinkisemils
force-pushed
the
separate-icmp-reads-from-writes-ios-852
branch
2 times, most recently
from
635f8cd
to
da446ea
Compare
buggmagnet
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Please remove Pinger.swift and PingerTests.swift too
Reviewable status: 0 of 3 files reviewed, all discussions resolved
pinkisemils
force-pushed
the
separate-icmp-reads-from-writes-ios-852
branch
from
da446ea
to
a09ff42
Compare
pinkisemils
commented
Oct 2, 2024
There was a problem hiding this comment.
Removed.
Reviewable status: 0 of 5 files reviewed, all discussions resolved
buggmagnet
previously approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
force-pushed
the
separate-icmp-reads-from-writes-ios-852
branch
from
856e69c
to
8893990
Compare
pinkisemils
force-pushed
the
separate-icmp-reads-from-writes-ios-852
branch
from
8893990
to
3fee766
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wireguard-applehas been changed to disjoin sending and receiving ICMP echo's and their responses. These changes accomodate that behavior in the ping monitor.This change is