Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise custom schemas in ci ios 448 #5766

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Feb 5, 2024

This is another test


This change is Reviewable

Copy link

linear bot commented Feb 5, 2024

@buggmagnet buggmagnet closed this Feb 5, 2024
@buggmagnet buggmagnet reopened this Feb 5, 2024
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


.github/workflows/ios-validate-build-schemas.yml line 7 at r2 (raw file):

    types:
      - opened
      - reopened

Just remove these and then it should be only executed when merging to main.

Code quote:

    types:
      - opened
      - reopened

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)


.github/workflows/ios-validate-build-schemas.yml line 18 at r2 (raw file):

  workflow_dispatch:
jobs:
  test:

This is missing a if: github.event.pull_request.merged == true, as per the docs.

@buggmagnet buggmagnet force-pushed the exercise-custom-schemas-in-ci-ios-448 branch 2 times, most recently from 85e3a7b to dcc9214 Compare February 5, 2024 11:57
Copy link
Contributor Author

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @pinkisemils)


.github/workflows/ios-validate-build-schemas.yml line 7 at r2 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

Just remove these and then it should be only executed when merging to main.

Done.


.github/workflows/ios-validate-build-schemas.yml line 18 at r2 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

This is missing a if: github.event.pull_request.merged == true, as per the docs.

Done.

@buggmagnet buggmagnet self-assigned this Feb 5, 2024
@buggmagnet buggmagnet added the iOS Issues related to iOS label Feb 5, 2024
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the exercise-custom-schemas-in-ci-ios-448 branch from dcc9214 to fdbe074 Compare February 7, 2024 14:21
@buggmagnet buggmagnet merged commit 00de763 into main Feb 7, 2024
3 checks passed
@buggmagnet buggmagnet deleted the exercise-custom-schemas-in-ci-ios-448 branch February 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants