-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exercise custom schemas in ci ios 448 #5766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
.github/workflows/ios-validate-build-schemas.yml
line 7 at r2 (raw file):
types: - opened - reopened
Just remove these and then it should be only executed when merging to main
.
Code quote:
types:
- opened
- reopened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
.github/workflows/ios-validate-build-schemas.yml
line 18 at r2 (raw file):
workflow_dispatch: jobs: test:
This is missing a if: github.event.pull_request.merged == true
, as per the docs.
85e3a7b
to
dcc9214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @pinkisemils)
.github/workflows/ios-validate-build-schemas.yml
line 7 at r2 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Just remove these and then it should be only executed when merging to
main
.
Done.
.github/workflows/ios-validate-build-schemas.yml
line 18 at r2 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
This is missing a
if: github.event.pull_request.merged == true
, as per the docs.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
dcc9214
to
fdbe074
Compare
This is another test
This change is