Exclude extension page from proxying

mullvad · Aug 14, 2024 · ce26c58 · ce26c58
1 parent f625848
commit ce26c58
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/components/Proxy/HomeProxyStatus.vue b/src/components/Proxy/HomeProxyStatus.vue
@@ -7,7 +7,7 @@ import useActiveTab from '@/composables/useActiveTab';
 import { ConnectionKey, defaultConnection } from '@/composables/useConnection';
 import useSocksProxy from '@/composables/useSocksProxy';
 
-const { activeTabHost, isAboutPage } = useActiveTab();
+const { activeTabHost, isBrowserPage } = useActiveTab();
 const {
   currentHostProxyDetails,
   currentHostProxyEnabled,
@@ -33,7 +33,7 @@ const currentHostExcluded = computed(() => {
   </IconLabel>
 
   <IconLabel
-    v-if="globalProxyEnabled && connection.isMullvad && !isAboutPage"
+    v-if="globalProxyEnabled && connection.isMullvad && !isBrowserPage"
     type="info"
     class="my-2"
   >

diff --git a/src/composables/useActiveTab.ts b/src/composables/useActiveTab.ts
@@ -2,19 +2,20 @@ import { getActiveTabDetails } from '@/helpers/socksProxy';
 import { ref } from 'vue';
 
 const activeTabHost = ref('');
-const isAboutPage = ref(false);
+const isBrowserPage = ref(false);
 
 const getActiveTab = async () => {
   const activeTabDetails = await getActiveTabDetails();
 
   activeTabHost.value = activeTabDetails.host;
-  isAboutPage.value = activeTabDetails.protocol === 'about:';
+  isBrowserPage.value =
+    activeTabDetails.protocol === 'about:' || activeTabDetails.protocol === 'moz-extension:';
 };
 
 const useActiveTab = () => {
   getActiveTab();
 
-  return { activeTabHost, isAboutPage };
+  return { activeTabHost, isBrowserPage };
 };
 
 export default useActiveTab;
diff --git a/src/popup/views/Proxy.vue b/src/popup/views/Proxy.vue
@@ -14,7 +14,7 @@ import { ConnectionKey, defaultConnection } from '@/composables/useConnection';
 import useListProxies from '@/composables/useListProxies';
 import useProxyPermissions from '@/composables/useProxyPermissions';
 
-const { isAboutPage } = useActiveTab();
+const { isBrowserPage } = useActiveTab();
 const { getSocksProxies } = useListProxies();
 const { proxyPermissionsGranted, triggerRequestProxyPermissions } = useProxyPermissions();
 
@@ -40,7 +40,7 @@ onMounted(loadProxies);
     </IconLabel>
 
     <div>
-      <ProxyHost v-if="!isAboutPage" />
+      <ProxyHost v-if="!isBrowserPage" />
       <ProxyGlobal />
       <LocationDrawer />
     </div>