Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URL address text padding when urlbar is in focus but not open. #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HomemadeToast57
Copy link

Describe the bug
The vertical padding (specifically top padding) of the URL address text is incorrect within its container when you open or switch to a new tab and have focus on the search bar.

To Reproduce
Steps to reproduce the behavior:

  1. Install MaterialFox chrome folder and user.js to profile root directory
  2. Restart Firefox
  3. Open new tab or click on address bar -> switch tabs -> return back to original tab (make sure you are not in the focus mode where it shows you autocomplete suggestions list)

Screenshot BEFORE fix
Look at the URL text inside the address bar...
Screen Shot 2022-07-24 at 3 08 47 PM
System info

  • OS: MacOS
  • Firefox version: 103.0b9

How I fixed it
On line #208 in chrome/urlbar/urlbar.css, I separated the horizontal and vertical padding values for the URL address text within the address bar. I noticed that it was setting ALL padding (every direction) to 0 but the desired styling was 0 padding for the horizontal directions (left and right) and automatic (evenly spaced) padding for the vertical directions (top and bottom). Below is the line of code I changed:

from
	padding: 0 !important;
to
	padding: 0 auto !important;

Screenshot AFTER fix
Look at the URL text inside the address bar...
Screen Shot 2022-07-24 at 3 34 29 PM

Hope this helps!

@HomemadeToast57
Copy link
Author

(Connecting this PR to original issue)
This fixes #324.

M0kh added a commit to M0kh/MaterialFox-Updated that referenced this pull request Aug 12, 2022
Added "Fixed URL address text padding when urlbar is in focus but not open" from muckSponge#325
kurbaniec added a commit to kurbaniec/Kacper-s-MaterialFox-Plus that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant