Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for different owner access to stream #115

Closed
wants to merge 1 commit into from

Conversation

danschultzer
Copy link
Contributor

Based on #101. This gives you better feedback for when the connection unexpectedly closes calling send_resp from another process. Without this you only see:

16:18:05.922 [warning] Header timestamp couldn't be fetched from ETS cache

16:18:05.925 [warning] Stream 3 completed in unexpected state remote_closed

That makes it difficult to understand what happens unless you go through the whole code path that includes GenServer messages (took me some time to figure out). With this PR you instead get these warnings:

16:18:05.922 [warning] Header timestamp couldn't be fetched from ETS cache

16:18:05.925 [warning] Stream 3 was handled by #PID<0.4048.0> but MUST be handled by #PID<0.4366.0>, the connection will complete unexpectedly

16:18:05.925 [warning] Stream 3 was handled by #PID<0.4048.0> but MUST be handled by #PID<0.4366.0>, the connection will complete unexpectedly

16:18:05.925 [warning] Stream 3 completed in unexpected state remote_closed

But the conn response is odd since status will be a nil value and empty body.

@mtrudel
Copy link
Owner

mtrudel commented Mar 26, 2023

I like this code! But #117 would make this unnecessary.

@danschultzer
Copy link
Contributor Author

#117 looks good, closing this!

@danschultzer danschultzer deleted the owner-warning branch March 26, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants