Only save Process keys that are atoms starting with $ (#351)

mtrudel · May 10, 2024 · e1a34f9 · e1a34f9
1 parent 53fdf06
commit e1a34f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/bandit/http1/handler.ex b/lib/bandit/http1/handler.ex
@@ -33,8 +33,12 @@ defmodule Bandit.HTTP1.Handler do
   end
 
   defp clear_process_dict do
-    Enum.each(Process.get_keys(), fn key ->
-      if !match?("$" <> _, to_string(key)), do: Process.delete(key)
+    Enum.each(Process.get_keys(), fn
+      key when is_atom(key) ->
+        if !match?("$" <> _, to_string(key)), do: Process.delete(key)
+
+      key ->
+        Process.delete(key)
     end)
   end
 

diff --git a/test/bandit/http1/request_test.exs b/test/bandit/http1/request_test.exs
@@ -250,6 +250,7 @@ defmodule HTTP1RequestTest do
         Process.get() |> Keyword.drop(~w[$ancestors $initial_call]a)
 
       Process.put(:garbage, :garbage)
+      Process.put({:garbage, :test}, :garbage)
       send_resp(conn, 200, inspect(existing_pdict))
     end