Expose body read timeouts as 408 Request Timeout errors (#385)

mtrudel · Aug 1, 2024 · d8056ec · d8056ec
1 parent af19424
commit d8056ec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/bandit/http1/socket.ex b/lib/bandit/http1/socket.ex
@@ -313,7 +313,7 @@ defmodule Bandit.HTTP1.Socket do
           end
 
         {:error, :timeout} ->
-          already_read
+          request_error!("Body read timeout", :request_timeout)
 
         {:error, reason} ->
           request_error!(reason)

diff --git a/test/bandit/http1/request_test.exs b/test/bandit/http1/request_test.exs
@@ -875,17 +875,16 @@ defmodule HTTP1RequestTest do
             "POST /short_body HTTP/1.1\r\nhost: localhost\r\ncontent-length: 5\r\n\r\nABC"
           )
 
-          assert {:ok, "200 OK", _, "OK"} = SimpleHTTP1Client.recv_reply(client)
+          assert {:ok, "408 Request Timeout", _, ""} = SimpleHTTP1Client.recv_reply(client)
           Process.sleep(1100)
         end)
 
-      assert errors =~ "(Bandit.HTTPError) Unable to read remaining data in request body"
+      assert errors =~ "(Bandit.HTTPError) Body read timeout"
     end
 
     def short_body(conn) do
-      {:more, "ABC", conn} = Plug.Conn.read_body(conn)
-      {:more, "", conn} = Plug.Conn.read_body(conn)
-      send_resp(conn, 200, "OK")
+      Plug.Conn.read_body(conn)
+      raise "Shouldn't get here"
     end
 
     test "handles the case where the declared content length is less than what is sent",