Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install and discard bad behaviour #7826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Oct 17, 2024

I did a few things here.

  • First, you cannot drag cards during select prompts. This should prevent unwitting players from discarding from hq in the wrong way, or trashing programs in the wrong during install.
  • Second, if you opt to trash some programs (but not enough), we can retry the install and ask again (I wish there was a trivial way to determine if enough MU was selected, but there are probably issues with it and effects)
  • Third, you cannot attempt to trash the host of a card you are installing during installation (according to the rules team). I added a function in hosting to check if a card happens to be an ancestor of another card to facilitate this. This is nice, because doing that before actually locked up the game without presenting any errors, so we get a double-whammy here.

Closes #7824
Closes #6893 (by preventing the player from discarding like that)

(when (and (not= src server)
(same-side? s (:side card))
(not= :select (get-in @state [side :prompt-state :prompt-type]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants