Adding ID to Lobby hover text #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #6925 the lobby hover text for deck faction was changed from
idtofaction. This allowed screen reader users to hear a more accurate representation of the icon that was shown to sighted users. However, this removed a feature from sighted users that allowed them to determine what the IDs used in a game were before spectating it.As a quick fix compromise, this PR concatenates the Faction and ID together, to provide the information that was previously only available to sighted users.
I know nothing is more permanent than a temporary solution, but I feel we should put some attention into site accessibility in the future. I am going to speak with some of colleagues who are accessibility engineers about appropriate ways to start that effort.