Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairphone 3 speaker support #137

Draft
wants to merge 3 commits into
base: 6.4.7/main
Choose a base branch
from

Conversation

z3ntu
Copy link

@z3ntu z3ntu commented Sep 23, 2023

Imports downstream amplifier driver (which isn't pretty of course, but works...).

Not quite sure how to handle the required #if 0 in msm8953.dtsi I added (which are necessary because FP3 doesn't use wcd_codec). Should we just move this out of msm8953.dtsi into the device dts which do use wcd_codec?

If that's resolved, I'll of course rework the commits and make them prettier.

FP3 doesn't use wcd_codec, remove bits from msm8953.dtsi

Commands:
echo start | sudo tee /sys/class/remoteproc/remoteproc0/state
amixer -c0 cset name='QUIN_MI2S_RX Audio Mixer MultiMedia1' 1
amixer -c0 cset name='aw8898_speaker_switch' 1
aplay -D plughw:0,0 testfiles/03.wav
@barni2000
Copy link
Member

barni2000 commented Nov 27, 2023

Imports downstream amplifier driver (which isn't pretty of course, but works...).

Not quite sure how to handle the required #if 0 in msm8953.dtsi I added (which are necessary because FP3 doesn't use wcd_codec). Should we just move this out of msm8953.dtsi into the device dts which do use wcd_codec?

If that's resolved, I'll of course rework the commits and make them prettier.

You could override audio-routing and maybe we could add a label for dai-link and than you can delete it with /delete-node/.

@z3ntu
Copy link
Author

z3ntu commented Nov 27, 2023

I'd mostly say non-common stuff (like the stuff I commented out) just shouldn't be in msm8953.dtsi but should be in device dts or so.

@barni2000
Copy link
Member

I'd mostly say non-common stuff (like the stuff I commented out) just shouldn't be in msm8953.dtsi but should be in device dts or so.

I understand audio-routing could be moved out because it is different on almost every device, but what about the dai-link many device uses the wcd_codec, i don't really like the approach duplicating stuffs. With a label you could override the sound-dai property. Or other solution define sound_card node from scratch for FP3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants