Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/genotype #37

Closed
wants to merge 19 commits into from
Closed

Feature/genotype #37

wants to merge 19 commits into from

Conversation

buehlere
Copy link
Collaborator

@buehlere buehlere commented Feb 8, 2024

PR checklist

Closes #28 and partly closes #39

  • adding genotype variant module.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • nf-test test --profile=docker --tag
    • nf-test test --profile=singularity --tag
    • nf-test test --profile=conda --tag (As of now not planning to support conda)

@buehlere buehlere changed the base branch from main to develop February 8, 2024 18:58
@@ -710,4 +711,9 @@ params {
}
}
}
test_data_msk {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should talk about test_data tomorrow at our meeting to get some consistency across some of our modules or have a main branch we work off of in test dataset. In n-f core they have the main modules branch and branches for each pipeline.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, referencing: #26

@buehlere buehlere marked this pull request as ready for review February 12, 2024 16:34
@buehlere buehlere closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: genotype_variants
2 participants