Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop configurability of global resources #48

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Drop configurability of global resources #48

merged 4 commits into from
Jul 26, 2023

Conversation

richfitz
Copy link
Member

Nobody (except one case) actually modified this. We can always add it back in later.

With this out, only plugins use the yml, and soon we can squash them out.

I do wonder (somewhat separately) if we should move from global to shared?

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f6f67cd) 100.00% compared to head (4ce5053) 100.00%.

❗ Current head 4ce5053 differs from pull request most recent head 8f9e658. Consider uploading reports for the commit 8f9e658 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main       #48     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           10        35     +25     
  Lines          581      2766   +2185     
===========================================
+ Hits           581      2766   +2185     
Impacted Files Coverage Δ
R/interactive.R 100.00% <ø> (ø)
R/cleanup.R 100.00% <100.00%> (ø)
R/config.R 100.00% <100.00%> (ø)
R/evaluate.R 100.00% <100.00%> (ø)
R/metadata.R 100.00% <100.00%> (ø)
R/orderly.R 100.00% <100.00%> (ø)
R/outpack_checksum.R 100.00% <100.00%> (ø)
R/outpack_config.R 100.00% <100.00%> (ø)
R/outpack_hash.R 100.00% <100.00%> (ø)
R/outpack_helpers.R 100.00% <100.00%> (ø)
... and 22 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richfitz richfitz marked this pull request as ready for review July 25, 2023 15:13
@richfitz richfitz requested a review from r-ash July 25, 2023 15:14
Copy link
Contributor

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I like shared too

@r-ash r-ash merged commit fe36f77 into main Jul 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants