Clean up generated files from source directory #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes some way to support the old
orderly_develop_statusandorderly_develop_cleanworkflow from before. There are differences though as we no longer have any expectation of a full file list from reading the orderly metadata.The approach here then is driven from the files we see, which we then try and classify - we can score things as the orderly.R file, resources, global resources, dependencies, or artefacts. The last three types need deleting when we clean up.
@kgaythorpe made the excellent suggestion of encouraging people to use .gitignore, and I remembered that libgit2 has the ability to tell if a file is gitignored, so with very recent gert we can use this to find files that the user probably wants gone: r-lib/gert#204
There are some fixes here to metadata handling that were required to make this work.
I'd like some feedback on if the names are right, but at the same time we have a big rename coming up soon. I've indicated in the doc that the status type is unstable, andI imagine that we'll put a format method on that at some point