Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end, very small changes to the schema ahead of moving it into its own repo, I think this is probably reasonable. The biggest changes:
session
from top-level schema, move into the custom orderly onepackages
from the orderly one, we're not even populating thislocation
is a compulsory entry in the config schema (otherwise we don't know what local refers to)scripts
from the top-level schema as it was alwaysorderly.R
and can just go in the custom schema now if people need itOther changes:
locationId
tolocation-id
,id
topacket-id
)time
property must includestart
andend
buy may include other things, so long as they are also numbersargs
field was left out of the location configurationhash
field to the deserialised metadata contents (I'd forgotten about this and got confused when spotting it)I did wonder about:
size
from the file path/hash/size object, but we use that inoutpack_server
and the alternative there feels worse (having to hit the store to check the size). At the same time it is strictly redundant as it is implied (though unknowable) from the hash, and makes me wonder how/if we'd cope with an inconsistency there. It's also somewhat ill defined for text files if the encoding is liable to change.time
element, arestart
andend
really special? they probably are.scripts
: this one feels not that interesting, but at the same time once I dropped it it felt wrong too. So I put it back, but this is one that I think is worth potentially being ruthless aboutsession
: I think this should move inside the orderly metadata part, and might just do that. Thoughts?