Allow custom locations to be added #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Looks good, "custom" sounds good to me. Though I suppose if we add another "custom" type at some point which is supported in Rust or Python then we'll have to do some switching on the first arg to a custom. Instead of just checking the name itself. But I think that's probably fine?
|
yeah, I really don't know how this is going to go in practice with another implementation (that's really why I left that comment about future change there). I expect we'll need to move things around a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit ropey, and worth chatting about. In particular, I wonder if instead of "custom" type we might use something like the fully qualified driver name as the type? Not sure, really. The issue here is that we expect that other outpack implementations (e.g. a python or rust one) pointed at this archive need to know that they don't need to stress about the location entry.
Look at mrc-ide/orderly.sharepoint#1 for the implementation of a custom driver that inspired this.