Add support for specifying Packit tokens directly. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of experimenting with new authentication methods for Packit, it is useful to be able to provide Packit tokens directly to orderly2. Until now, orderly2 would only accept GitHub tokens, and would perform a request to exchange it for a Packit token. Thankfully, GitHub tokens have a [well defined and documented prefix][ghblog], of the form `ghp_`, `gho_`, ... The underscore makes sure it so that it never could never be confused with a JWT. Thanks to this, the distinction between Packit and GitHub tokens is unambiguous. Eventually we may want to implement some of these authentication methods in orderly2 itself, but it the meantime this makes experimentation easier. [ghblog]: https://github.blog/engineering/platform-security/behind-githubs-new-authentication-token-formats/
|
For an example of this being used https://github.com/plietar/orderly-ci-test/blob/f1987986d5fceeaf7b4cceb9aacf2708ae776f0a/run.R We'll probably want to export that code somewhere, either in orderly2 or in a reusable action. |
richfitz
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of experimenting with new authentication methods for Packit, it is useful to be able to provide Packit tokens directly to orderly2. Until now, orderly2 would only accept GitHub tokens, and would perform a request to exchange it for a Packit token.
Thankfully, GitHub tokens have a well defined and documented prefix, of the form
ghp_,gho_, ... The underscore makes sure it so that it never could never be confused with a JWT. Thanks to this, the distinction between Packit and GitHub tokens is unambiguous.Eventually we may want to implement some of these authentication methods in orderly2 itself, but it the meantime this makes experimentation easier.