Skip to content

Commit

Permalink
Add extra ghc options to multi-repl file
Browse files Browse the repository at this point in the history
These options are configured into the program by Cabal, so we also need
to extract these and put them into the mutli-file.

Fixes haskell#10015
  • Loading branch information
mpickering committed May 30, 2024
1 parent 3a8c69c commit 7097104
Show file tree
Hide file tree
Showing 9 changed files with 111 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Cabal/src/Distribution/Simple/GHC/Build/Link.hs
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,9 @@ runReplOrWriteFlags ghcProg lbi rflags ghcOpts pkg_name target =
writeFileAtomic (out_dir </> this_unit) $
BS.pack $
escapeArgs $
extra_opts ++ renderGhcOptions comp platform (ghcOpts{ghcOptMode = NoFlag})
extra_opts
++ renderGhcOptions comp platform (ghcOpts{ghcOptMode = NoFlag})
++ programOverrideArgs ghcProg

replNoLoad :: Ord a => ReplOptions -> NubListR a -> NubListR a
replNoLoad replFlags l
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Revision history for extra-options

## 0.1.0.0 -- YYYY-mm-dd

* First version. Released on an unsuspecting world.
30 changes: 30 additions & 0 deletions cabal-testsuite/PackageTests/MultiRepl/ExtraOptions/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
Copyright (c) 2024, Matthew Pickering

All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.

* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.

* Neither the name of Matthew Pickering nor the names of other
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
10 changes: 10 additions & 0 deletions cabal-testsuite/PackageTests/MultiRepl/ExtraOptions/app/Main.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module Main where

import qualified MyLib (someFunc)

#ifdef FOO
main :: IO ()
main = do
putStrLn "Hello, Haskell!"
MyLib.someFunc
#endif
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
packages: .

tests: True

program-options
ghc-options: -XCPP -DFOO
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import Test.Cabal.Prelude

main = do
cabalTest $ do
skipUnlessGhcVersion ">= 9.4"
void $ cabalWithStdin "v2-repl" ["--enable-multi-repl","all"] ""
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
cabal-version: 3.0
name: extra-options
version: 0.1.0.0
license: BSD-3-Clause
license-file: LICENSE
author: Matthew Pickering
maintainer: [email protected]
build-type: Simple
extra-doc-files: CHANGELOG.md

common warnings
ghc-options: -Wall

library
import: warnings
exposed-modules: MyLib
build-depends: base
hs-source-dirs: src
default-language: Haskell2010

executable extra-options
import: warnings
main-is: Main.hs
build-depends:
base,
extra-options

hs-source-dirs: app
default-language: Haskell2010

test-suite extra-options-test
import: warnings
default-language: Haskell2010
type: exitcode-stdio-1.0
hs-source-dirs: test
main-is: Main.hs
build-depends:
base,
extra-options
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module MyLib (someFunc) where

#ifdef FOO
someFunc :: IO ()
someFunc = putStrLn "someFunc"
#endif
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module Main (main) where

#ifdef FOO
main :: IO ()
main = putStrLn "Test suite not yet implemented."
#endif

0 comments on commit 7097104

Please sign in to comment.