Skip to content

Commit

Permalink
Filter out -dinitial-unique and -dunique-increment from hash flags
Browse files Browse the repository at this point in the history
These options shouldn't affect the output of the package and hence
shouldn't affect the store hash of a package.
  • Loading branch information
mpickering authored and Mikolaj committed Aug 15, 2024
1 parent 30d2a38 commit 4ce7bc4
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Cabal/src/Distribution/Simple/Program/GHC.hs
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,8 @@ normaliseGhcArgs (Just ghcVersion) PackageDescription{..} ghcArgs
, "-ddpr-cols"
, "-dtrace-level"
, "-fghci-hist-size"
, "-dinitial-unique"
, "-dunique-increment"
]
, from [8, 2] ["-fmax-uncovered-patterns", "-fmax-errors"]
, from [8, 4] $ to [8, 6] ["-fmax-valid-substitutions"]
Expand Down
13 changes: 13 additions & 0 deletions changelog.d/pr-10240
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
synopsis: Filter out dinitial-unique and dunique-increment from package hash
packages: cabal-install
prs: #10122

description: {

`-dinitial-unique` and `-dunique-increment` are now filtered out when computing the
store hash of a package.

These options shouldn't affect the output of the package and hence
shouldn't affect the store hash of a package.

}

0 comments on commit 4ce7bc4

Please sign in to comment.