Add links from Perfherder's Alerts View to PerfCompare (#8244)

* Add links to PerfCompare in Alerts View * Correct function names
mozilla · Oct 14, 2024 · ae3da6e · ae3da6e
1 parent b3e21c4
commit ae3da6e
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 50 deletions.
diff --git a/ui/helpers/url.js b/ui/helpers/url.js
@@ -166,3 +166,47 @@ export const updateQueryParams = function updateHistoryWithQueryParams(
 
 export const getPernoscoURL = (taskId) =>
   `https://pernos.co/self-service-api/mozilla/${taskId}/self-service.html`;
+
+export const getPerfCompareBaseURL = function getOldCompareWithBaseViewURL(
+  originalProject,
+  originalRevision,
+  newProject,
+  newRevision,
+  framework,
+) {
+  return `https://perf.compare/compare-results?baseRev=${originalRevision}&baseRepo=${originalProject}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}`;
+};
+
+export const getPerfCompareBaseSubtestsURL = function getPerfCompareBaseSubtestsURL(
+  originalProject,
+  originalRevision,
+  newProject,
+  newRevision,
+  framework,
+  originalSignature,
+  newSignature,
+) {
+  return `https://perf.compare/subtests-compare-results?baseRev=${originalRevision}&baseRepo=${originalProject}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}&baseParentSignature=${originalSignature}&newParentSignature=${newSignature}`;
+};
+
+export const getPerfCompareOvertimeURL = function getPerfCompareOvertimeURL(
+  originalProject,
+  newProject,
+  newRevision,
+  framework,
+  timeRange,
+) {
+  return `https://perf.compare/compare-over-time-results?baseRepo=${originalProject}&selectedTimeRange=${timeRange}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}`;
+};
+
+export const getPerfCompareOvertimeSubtestsURL = function getPerfCompareOvertimeSubtestsURL(
+  originalProject,
+  newProject,
+  newRevision,
+  framework,
+  timeRange,
+  originalSignature,
+  newSignature,
+) {
+  return `https://perf.compare/subtests-compare-over-time-results?baseRepo=${originalProject}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}&selectedTimeRange=${timeRange}&baseParentSignature=${originalSignature}&newParentSignature=${newSignature}`;
+};
diff --git a/ui/perfherder/alerts/AlertHeader.jsx b/ui/perfherder/alerts/AlertHeader.jsx
@@ -10,7 +10,7 @@ import {
   Col,
 } from 'reactstrap';
 
-import { getJobsUrl } from '../../helpers/url';
+import { getJobsUrl, getPerfCompareBaseURL } from '../../helpers/url';
 import { toMercurialShortDateStr } from '../../helpers/display';
 import SimpleTooltip from '../../shared/SimpleTooltip';
 
@@ -58,6 +58,21 @@ const AlertHeader = ({
               tooltipText="Alert Summary created"
             />
           </Row>
+          <Row className="m-0 px-0 py-0">
+            <a
+              href={getPerfCompareBaseURL(
+                alertSummary.repository,
+                alertSummary.prev_push_revision,
+                alertSummary.repository,
+                alertSummary.revision,
+                alertSummary.framework,
+              )}
+              target="_blank"
+              rel="noopener noreferrer"
+            >
+              PerfCompare comparison
+            </a>
+          </Row>
         </Col>
         <Col className="p-0" xs="auto">
           <UncontrolledDropdown tag="span">

diff --git a/ui/perfherder/compare/CompareTableView.jsx b/ui/perfherder/compare/CompareTableView.jsx
@@ -15,7 +15,14 @@ import {
 } from '../perf-helpers/constants';
 import ErrorBoundary from '../../shared/ErrorBoundary';
 import { getData } from '../../helpers/http';
-import { createApiUrl, createQueryParams } from '../../helpers/url';
+import {
+  createApiUrl,
+  createQueryParams,
+  getPerfCompareBaseURL,
+  getPerfCompareOvertimeURL,
+  getPerfCompareBaseSubtestsURL,
+  getPerfCompareOvertimeSubtestsURL,
+} from '../../helpers/url';
 import {
   getFrameworkData,
   scrollWithOffset,
@@ -29,50 +36,6 @@ import RevisionInformation from '../../shared/RevisionInformation';
 import CompareTableControls from './CompareTableControls';
 import NoiseTable from './NoiseTable';
 
-export const getPerfCompareCompareBaseURL = function getOldCompareWithBaseViewURL(
-  originalProject,
-  originalRevision,
-  newProject,
-  newRevision,
-  framework,
-) {
-  return `https://perf.compare/compare-results?baseRev=${originalRevision}&baseRepo=${originalProject}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}`;
-};
-
-export const getPerfCompareCompareBaseSubtestsURL = function getPerfCompareCompareBaseSubtestsURL(
-  originalProject,
-  originalRevision,
-  newProject,
-  newRevision,
-  framework,
-  originalSignature,
-  newSignature,
-) {
-  return `https://perf.compare/subtests-compare-results?baseRev=${originalRevision}&baseRepo=${originalProject}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}&baseParentSignature=${originalSignature}&newParentSignature=${newSignature}`;
-};
-
-export const getPerfCompareCompareOvertimeURL = function getPerfCompareCompareOvertimeURL(
-  originalProject,
-  newProject,
-  newRevision,
-  framework,
-  timeRange,
-) {
-  return `https://perf.compare/compare-over-time-results?baseRepo=${originalProject}&selectedTimeRange=${timeRange}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}`;
-};
-
-export const getPerfCompareCompareOvertimeSubtestsURL = function getPerfCompareCompareOvertimeSubtestsURL(
-  originalProject,
-  newProject,
-  newRevision,
-  framework,
-  timeRange,
-  originalSignature,
-  newSignature,
-) {
-  return `https://perf.compare/subtests-compare-over-time-results?baseRepo=${originalProject}&newRev=${newRevision}&newRepo=${newProject}&framework=${framework}&selectedTimeRange=${timeRange}&baseParentSignature=${originalSignature}&newParentSignature=${newSignature}`;
-};
-
 export default class CompareTableView extends React.Component {
   constructor(props) {
     super(props);
@@ -316,7 +279,7 @@ export default class CompareTableView extends React.Component {
     if (originalRevision) {
       // compare with base url
       perfCompareURL = hasSubtests
-        ? getPerfCompareCompareBaseSubtestsURL(
+        ? getPerfCompareBaseSubtestsURL(
             originalProject,
             originalRevision,
             newProject,
@@ -325,7 +288,7 @@ export default class CompareTableView extends React.Component {
             originalSignature,
             newSignature,
           )
-        : getPerfCompareCompareBaseURL(
+        : getPerfCompareBaseURL(
             originalProject,
             originalRevision,
             newProject,
@@ -335,7 +298,7 @@ export default class CompareTableView extends React.Component {
     } else if (timeRange) {
       // compareOverTime URL
       perfCompareURL = hasSubtests
-        ? getPerfCompareCompareOvertimeSubtestsURL(
+        ? getPerfCompareOvertimeSubtestsURL(
             originalProject,
             newProject,
             newRevision,
@@ -344,7 +307,7 @@ export default class CompareTableView extends React.Component {
             originalSignature,
             newSignature,
           )
-        : getPerfCompareCompareOvertimeURL(
+        : getPerfCompareOvertimeURL(
             originalProject,
             newProject,
             newRevision,