Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mocha+RSVP based unit tests #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juandopazo
Copy link

Hi!

I'm interested in adding support for ES6 generators, but I thought I'd first resolve #2 and start by adding a test suite, so that there something to test against when adding ES6 support.

The suite includes tests for the behavior of spawn and it deliberately doesn't include tests for the promises part of Task.js. I agree that eventually it'll be a better idea to use another promises library. That is also why test promises are created with RSVP.

It still needs tests for pausing and resuming tasks, the other methods available in Task and possibly the Scheduler.

I decided to overwrite Mocha's it function to simplify catching assertion errors that would otherwise be caught by Task.js. That way tests look like this:

it('should retrieve a promise\'s value', function (done) {
    var expected = 'hello world';

    spawn(function () {
        var actual = yield Promise.resolve(expected);

        done(function () {
            expect(actual).to.equal(expected);
        });
    });
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test suite
1 participant