-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of clang version and v14+ unit tests #1878
Fix detection of clang version and v14+ unit tests #1878
Conversation
Compiler version (__VERSION__) is always enclosed in quotes. This only fixes version detection for clang to keep the scope small. Stripping quotes could also be done globally in compiler.rs.
would it be possible to have a test for this? |
It's two things - the unit test code itself was broken. Once it was fixes (test/system.rs), the problematic behavior was exposed. We could have a basic unit test of course (not really hard to do). Not sure how much it buys us, but also won't hurt... |
43d8e94
to
5ee7c72
Compare
5ee7c72
to
8cade2e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 29.80% 29.87% +0.07%
==========================================
Files 49 49
Lines 17516 17528 +12
Branches 8423 8430 +7
==========================================
+ Hits 5220 5237 +17
+ Misses 7212 7211 -1
+ Partials 5084 5080 -4
☔ View full report in Codecov by Sentry. |
c2fb5d2
to
d456957
Compare
@@ -252,6 +252,38 @@ mod test { | |||
} | |||
} | |||
|
|||
#[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Compiler version (
__VERSION__
) is always enclosed in quotes.This only fixes version detection for clang to keep the scope small.
Stripping quotes could also be done globally in compiler.rs.