Bring back redis over tls #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 29.88% 29.82% -0.06%
==========================================
Files 49 49
Lines 17538 17538
Branches 8443 8442 -1
==========================================
- Hits 5241 5231 -10
- Misses 7214 7215 +1
- Partials 5083 5092 +9 ☔ View full report in Codecov by Sentry. |
grembo
force-pushed
the
bring-back-redis-over-tls
branch
from
07eaba3
to
fd0dc29
Compare
|
Reduced the patch to the functional change (meaning that parts of CI will fail) |
grembo
force-pushed
the
bring-back-redis-over-tls
branch
2 times, most recently
from
ddda357
to
a4bd7f2
Compare
grembo
commented
Sep 5, 2023
sylvestre
force-pushed
the
bring-back-redis-over-tls
branch
from
a4bd7f2
to
7656480
Compare
This bumps opendal and reqsign (required to support rusttls)
Allows to remove the direct dependency on backon
grembo
force-pushed
the
bring-back-redis-over-tls
branch
from
4afb49b
to
91049b6
Compare
|
@sylvestre Now that main is already updated to opendal 0.40.0, this change is very simple (just bring in the feature to support rediss://) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1839