Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXVPN-201 - Decouple timers #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FXVPN-201 - Decouple timers #85

wants to merge 1 commit into from
+103 −32

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Oct 22, 2024

This moves the timer from the vpn-controller timer to the extension-controller. Also adding a few tests for that class.

Recording.2024-10-22.160121.mp4

lesleyjanenorton
lesleyjanenorton approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And here I was assuming the decoupled timers would be massively painful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesleyjanenorton lesleyjanenorton lesleyjanenorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strseb @lesleyjanenorton