Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in-use label and location picker behavior #68

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

lesleyjanenorton
Copy link
Member

Here we:

  • Remove the "in-use" label from vpn-card (FXVPN-169)
  • Add an "in-use" label to the location picker button that is
    • visible when a site-specific location setting is not in effect
    • hidden when the site is excluded
    • disable the location picker button when the site is excluded (FXVPN-167)
  • Makes some opportunistic UI tweaks
Screenshot 2024-09-25 at 12 39 21 PM Screenshot 2024-09-25 at 12 39 29 PM

@lesleyjanenorton lesleyjanenorton changed the title In use Update in-use label and location picker behavior Sep 25, 2024
Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought "in use" should still be on the card when using the default location?
but anyway lgtm

@lesleyjanenorton lesleyjanenorton merged commit 1415408 into main Sep 26, 2024
5 checks passed
@lesleyjanenorton
Copy link
Member Author

I thought "in use" should still be on the card when using the default location?
but anyway lgtm

@strseb Santiago changed the behavior yesterday after thinking about it some more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants