add UISearchController and footer view to CategoryListViewController 🕵️ #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmednaagy
changed the title
HebaMad
approved these changes
Aug 19, 2022
ahmednaagy
changed the title
Conflicts: Dokan/Dokan/Scenes/CategoryList/CategoryListViewController.swift
ahmdmhasn
reviewed
Sep 1, 2022
Comment on lines
87
to
88
|
|
||
| return CGSize(width: (collectionView.bounds.width / 2) - 20, height: 280) |
There was a problem hiding this comment.
Let's add constants to Metrics enum
Suggested change
| return CGSize(width: (collectionView.bounds.width / 2) - 20, height: 280) | |
| return CGSize(width: (collectionView.bounds.width / 2) - 20, height: 280) |
|
|
||
| class CategoryFooterReusableView: UICollectionReusableView { | ||
|
|
||
| static let identifier = "CategoryFooterReusableView" |
There was a problem hiding this comment.
Suggested change
| static let identifier = "CategoryFooterReusableView" | |
| static let identifier = "CategoryFooterReusableView" |
No need for identifier, you can use IdentifiableView instead.
Comment on lines
25
to
27
| public func configure() { | ||
| addSubview(button) | ||
| } |
There was a problem hiding this comment.
Why not adding it inside init?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.