feat: Add logic to product details screen #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmdmhasn
reviewed
Aug 16, 2022
ahmdyasser
changed the title
ziadali22
approved these changes
Aug 21, 2022
ahmdmhasn
reviewed
Aug 26, 2022
Dokan/Dokan/Scenes/ProductDetails/TitleQuantity/ProductTitleQuantityView.swift
Show resolved
Hide resolved
ahmdmhasn
reviewed
Sep 1, 2022
| @@ -14,4 +14,6 @@ public protocol ProductRepository { | |||
| /// Load all products at a page. Completes with products list or error if any. | |||
| /// | |||
| func loadProducts(at page: Int, completion: @escaping (Result<[Product], Error>) -> Void) | |||
|
|
|||
| func loadSingleProduct(productID: Int, completion: @escaping (Result<Product, Error>) -> Void) | |||
There was a problem hiding this comment.
Documentation would be better 😏
Dokan/Dokan/Scenes/ProductDetails/TitleQuantity/ProductTitleQuantityView.swift
Outdated
Show resolved
Hide resolved
Dokan/Dokan/Scenes/ProductDetails/TitleQuantity/ProductTitleQuantityView.swift
Outdated
Show resolved
Hide resolved
Comment on lines
48
to
78
| func initView() { | ||
| let model: tQViewModel = productViewModel.getproductViewModel() | ||
| configureView(viewModel: model) | ||
| changeStockBackGroundColor(stockCount: model.stockCount) | ||
| } | ||
|
|
||
| func initViewModel() { | ||
|
|
||
| productViewModel.uploadLoadingState = { [weak self] () in | ||
| guard let self = self else { return } | ||
|
|
||
| DispatchQueue.main.async { [weak self] in | ||
| guard let self = self else { return } | ||
|
|
||
| switch self.productViewModel.state { | ||
|
|
||
| case .loading, .error, .empty: | ||
| self.startSkeletonView() | ||
| case .populated: | ||
| self.stopSkeletonView() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| productViewModel.reloadViewClosure = { [weak self] () in | ||
| DispatchQueue.main.async { [weak self] in | ||
| self?.initView() | ||
| } | ||
| } | ||
|
|
||
| productViewModel.initFetchSingleProduct() |
There was a problem hiding this comment.
This code needs more enhancement to handle the case when the view model gets updated and follow single responsibility.
Dokan/Dokan/Scenes/ProductDetails/ProductDetailsViewModel.swift
Outdated
Show resolved
Hide resolved
Dokan/Dokan/Scenes/ProductDetails/ProductDetailsViewModel.swift
Outdated
Show resolved
Hide resolved
Dokan/Dokan/Scenes/ProductDetails/ProductDetailsViewModel.swift
Outdated
Show resolved
Hide resolved
Comment on lines
73
to
98
|
|
||
| func getproductViewModel() -> tQViewModel { | ||
| return titleQuantityViewModel! | ||
| } | ||
|
|
||
| func getImageview(indexPath: IndexPath) -> sliderViewModel { | ||
| return imageViewModel[indexPath.row] | ||
| } | ||
|
|
||
| private func createProductTitleQuantityView(product: Product) -> tQViewModel { | ||
|
|
||
| return tQViewModel(title: product.title, currency: "$", price: product.price, reviewAverage: 4.8, reviewCount: 23, stockCount: 8) | ||
| } | ||
|
|
||
| private func createProductImage(product: Product) -> sliderViewModel { | ||
|
|
||
| return sliderViewModel(productImage: product.thumbnailUrl) | ||
| } | ||
|
|
||
| func processFetchProduct(product: Product) { | ||
| self.product = product | ||
| var imgs = [sliderViewModel]() | ||
| titleQuantityViewModel = createProductTitleQuantityView(product: product) | ||
| imgs.append(createProductImage(product: product)) | ||
| imageViewModel = imgs | ||
| } |
There was a problem hiding this comment.
All these methods are not accessible in the controller since they're not defined in ProductDetailsViewModelOutput
There was a problem hiding this comment.
Will this fix it?
protocol ProductDetailsViewModelOutput {
func fetchProduct()
func getproductViewModel() -> TQViewModel
func getImageview(indexPath: IndexPath) -> sliderViewModel
func processFetchProduct(product: Product)
func createProductTitleQuantityView(product: Product) -> TQViewModel
func createProductImage(product: Product) -> sliderViewModel
}
Dokan/Dokan/Scenes/ProductDetails/ProductDetailsViewModel.swift
Outdated
Show resolved
Hide resolved
…antityView.swift Co-authored-by: Ahmed M. Hassan <[email protected]>
Co-authored-by: Ahmed M. Hassan <[email protected]>
Co-authored-by: Ahmed M. Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.