Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis plugins: support basis_universal 1.50 #119

Closed
wants to merge 30 commits into from

Commits on Sep 16, 2024

  1. Basis{ImageConverter,Importer}: add support for basis_universal 1.16

    Fully backwards compatible thanks to the new BASISU_LIB_VERSION/BASISD_LIB_VERSION.
    
    The OpenCL dependency is kind of brutal since it hard-links to the shared library. Is there a nicer way to configure this other than CMAKE_DISABLE_FIND_PACKAGE_OpenCL?
    pezcode committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    10b3877 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0737fba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fe4c1b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. package/ci: build Basis without OpenCL support on MSVC 2019

    To have at least one platform to test the library without OpenCL
    support built in
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3e54a7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49dffe3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fcbab58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ed58fc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    64b572d View commit details
    Browse the repository at this point in the history
  6. BasisImageConverter: actually test if this succeeded

    Otherwise, if the BasisImporter is missing, this tests nothing
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0290d45 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3482314 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d1d5837 View commit details
    Browse the repository at this point in the history
  9. BasisImageConverter: clarify docs about disabling OpenCL

    So that it's obvious that this works even without compiling from a
    subdirectory
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    42b66f9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8794419 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4634ee1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    277bbbf View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1155e4b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4603c5f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    68fa42c View commit details
    Browse the repository at this point in the history
  16. modules: don't search for OpenCL in QUIET mode

    So there's some helpful debug output
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f64da29 View commit details
    Browse the repository at this point in the history
  17. package/ci: Simplify Basis version selection for MSVC

    This still downloads and extracts Basis even if not built on MSVC 2015
    but it did that before as well, and making the preparation plus
    unzipping optional would be really annoying.
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3804463 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    8e81e5c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    01c0258 View commit details
    Browse the repository at this point in the history
  20. BasisImageConverter: copy compile definitions from the Encoder target

    To also apply the fixes required for GCC < 5
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f33d52a View commit details
    Browse the repository at this point in the history
  21. BasisImageConverter: disable asserts in Basis' OpenCL code

    When it doesn't find a GPU device, it falls back to a CPU device and
    prints a nice error along the way. Unfortunately, all OpenCL-related
    errors are accompanied by an assert that can't be turned off. There's
    BASISU_OPENCL_ASSERT_ON_ANY_ERRORS but that's always defined to 1 at the
    top of the file...
    
    So disable asserts via NDEBUG to actually get to use (and test) the
    OpenCL code in debug builds.
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5e7fd40 View commit details
    Browse the repository at this point in the history
  22. package/ci: find and compile against Apple's OpenCL implementation di…

    …rectly
    
    Apple's OpenCL implementation doesn't seem to support being used through
    the ICD, so you have to compile against it directly or use a wrapper.
    
    See also:
    https://portablecl.org/docs/html/using.html#using-pocl-on-macosx
    https://github.com/jrprice/ocl_icd_wrapper
    pezcode committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1226a9f View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    a1438e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf0d453 View commit details
    Browse the repository at this point in the history
  3. package/ci: don't test Basis with OpenCL on sanitizer builds

    Either Basis, or the OpenCL ICD loader, or the PoCL ICD, or the included
    LLVM cause tons of sanitizer errors. Not much we can do here.
    pezcode committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    407b036 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d328d8b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0f11752 View commit details
    Browse the repository at this point in the history