-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basis plugins: support basis_universal 1.50 #119
Commits on Sep 16, 2024
-
Basis{ImageConverter,Importer}: add support for basis_universal 1.16
Fully backwards compatible thanks to the new BASISU_LIB_VERSION/BASISD_LIB_VERSION. The OpenCL dependency is kind of brutal since it hard-links to the shared library. Is there a nicer way to configure this other than CMAKE_DISABLE_FIND_PACKAGE_OpenCL?
Configuration menu - View commit details
-
Copy full SHA for 10b3877 - Browse repository at this point
Copy the full SHA 10b3877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0737fba - Browse repository at this point
Copy the full SHA 0737fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe4c1b0 - Browse repository at this point
Copy the full SHA fe4c1b0View commit details
Commits on Sep 18, 2024
-
package/ci: build Basis without OpenCL support on MSVC 2019
To have at least one platform to test the library without OpenCL support built in
Configuration menu - View commit details
-
Copy full SHA for 3e54a7b - Browse repository at this point
Copy the full SHA 3e54a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49dffe3 - Browse repository at this point
Copy the full SHA 49dffe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcbab58 - Browse repository at this point
Copy the full SHA fcbab58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ed58fc - Browse repository at this point
Copy the full SHA 9ed58fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b572d - Browse repository at this point
Copy the full SHA 64b572dView commit details -
BasisImageConverter: actually test if this succeeded
Otherwise, if the BasisImporter is missing, this tests nothing
Configuration menu - View commit details
-
Copy full SHA for 0290d45 - Browse repository at this point
Copy the full SHA 0290d45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3482314 - Browse repository at this point
Copy the full SHA 3482314View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1d5837 - Browse repository at this point
Copy the full SHA d1d5837View commit details -
BasisImageConverter: clarify docs about disabling OpenCL
So that it's obvious that this works even without compiling from a subdirectory
Configuration menu - View commit details
-
Copy full SHA for 42b66f9 - Browse repository at this point
Copy the full SHA 42b66f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8794419 - Browse repository at this point
Copy the full SHA 8794419View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4634ee1 - Browse repository at this point
Copy the full SHA 4634ee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 277bbbf - Browse repository at this point
Copy the full SHA 277bbbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1155e4b - Browse repository at this point
Copy the full SHA 1155e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4603c5f - Browse repository at this point
Copy the full SHA 4603c5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68fa42c - Browse repository at this point
Copy the full SHA 68fa42cView commit details -
modules: don't search for OpenCL in QUIET mode
So there's some helpful debug output
Configuration menu - View commit details
-
Copy full SHA for f64da29 - Browse repository at this point
Copy the full SHA f64da29View commit details -
package/ci: Simplify Basis version selection for MSVC
This still downloads and extracts Basis even if not built on MSVC 2015 but it did that before as well, and making the preparation plus unzipping optional would be really annoying.
Configuration menu - View commit details
-
Copy full SHA for 3804463 - Browse repository at this point
Copy the full SHA 3804463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e81e5c - Browse repository at this point
Copy the full SHA 8e81e5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01c0258 - Browse repository at this point
Copy the full SHA 01c0258View commit details -
BasisImageConverter: copy compile definitions from the Encoder target
To also apply the fixes required for GCC < 5
Configuration menu - View commit details
-
Copy full SHA for f33d52a - Browse repository at this point
Copy the full SHA f33d52aView commit details -
BasisImageConverter: disable asserts in Basis' OpenCL code
When it doesn't find a GPU device, it falls back to a CPU device and prints a nice error along the way. Unfortunately, all OpenCL-related errors are accompanied by an assert that can't be turned off. There's BASISU_OPENCL_ASSERT_ON_ANY_ERRORS but that's always defined to 1 at the top of the file... So disable asserts via NDEBUG to actually get to use (and test) the OpenCL code in debug builds.
Configuration menu - View commit details
-
Copy full SHA for 5e7fd40 - Browse repository at this point
Copy the full SHA 5e7fd40View commit details -
package/ci: find and compile against Apple's OpenCL implementation di…
…rectly Apple's OpenCL implementation doesn't seem to support being used through the ICD, so you have to compile against it directly or use a wrapper. See also: https://portablecl.org/docs/html/using.html#using-pocl-on-macosx https://github.com/jrprice/ocl_icd_wrapper
Configuration menu - View commit details
-
Copy full SHA for 1226a9f - Browse repository at this point
Copy the full SHA 1226a9fView commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a1438e2 - Browse repository at this point
Copy the full SHA a1438e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf0d453 - Browse repository at this point
Copy the full SHA bf0d453View commit details -
package/ci: don't test Basis with OpenCL on sanitizer builds
Either Basis, or the OpenCL ICD loader, or the PoCL ICD, or the included LLVM cause tons of sanitizer errors. Not much we can do here.
Configuration menu - View commit details
-
Copy full SHA for 407b036 - Browse repository at this point
Copy the full SHA 407b036View commit details -
Configuration menu - View commit details
-
Copy full SHA for d328d8b - Browse repository at this point
Copy the full SHA d328d8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f11752 - Browse repository at this point
Copy the full SHA 0f11752View commit details