Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrade-rc: allow shorthand filename specification #163

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 1, 2023

  1. [wip] corrade-rc: allow shorthand filename specification.

    If no alias, nullTerminated or align options are needed or the global
    values are sufficient, having to write a [file] section for each file is
    overly verbose. This allows to specify filename= options directly in the
    global configuration section.
    
    It's filename= and not file= in order to not have to further complicate
    the CMake parsing routine that extract dependency information from the
    file -- this way it doesn't even need to be changed.
    
    TODO: while basic support for this was easy enough, the filesystem group
      override code needs to be adapted and tested for this, which involves
      copying the file somewhere temporary and changing the contents
      (because we can't make use of an alias in this scenario)
    TODO: there's also a newly uncovered bug, see the TODO in Resource.cpp
    TODO: this also needs to be documented
    mosra committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    77e8588 View commit details
    Browse the repository at this point in the history