Merge pull request FreeCAD#15734 from bgbsww/bgbsww-toponamingFixTopo…

…ShapeToHaveHasher Toponaming: make sure TopoShapes have Hashers
mosfet80 · Aug 5, 2024 · 4801300 · 4801300
2 parents 9b5b9cc + 19b6363
commit 4801300
Show file tree

Hide file tree

Showing 4 changed files with 331 additions and 305 deletions.
diff --git a/src/App/ComplexGeoData.cpp b/src/App/ComplexGeoData.cpp
@@ -296,6 +296,16 @@ ComplexGeoData::getElementMappedNames(const IndexedName& element, bool needUnmap
     return {std::make_pair(MappedName(element), ElementIDRefs())};
 }
 
+ElementMapPtr ComplexGeoData::resetElementMap(ElementMapPtr elementMap)
+{
+    _elementMap.swap(elementMap);
+    // We expect that if the ComplexGeoData ( TopoShape ) has a hasher, then its elementMap will
+    // have the same one.  Make sure that happens.
+    if ( _elementMap && ! _elementMap->hasher )
+        _elementMap->hasher = Hasher;
+    return elementMap;
+}
+
 std::vector<MappedElement> ComplexGeoData::getElementMap() const
 {
     flushElementMap();

diff --git a/src/App/ComplexGeoData.h b/src/App/ComplexGeoData.h
@@ -316,11 +316,7 @@ class AppExport ComplexGeoData: public Base::Persistence, public Base::Handled
      *
      * @return Returns the existing element map.
      */
-    virtual ElementMapPtr resetElementMap(ElementMapPtr elementMap = ElementMapPtr())
-    {
-        _elementMap.swap(elementMap);
-        return elementMap;
-    }
+    virtual ElementMapPtr resetElementMap(ElementMapPtr elementMap = ElementMapPtr());
 
     /// Get the entire element map
     std::vector<MappedElement> getElementMap() const;

diff --git a/src/App/Document.cpp b/src/App/Document.cpp
@@ -1075,7 +1075,6 @@ std::pair<bool,int> Document::addStringHasher(const StringHasherRef & hasher) co
 
 StringHasherRef Document::getStringHasher(int idx) const {
     if(idx<0) {
-            return d->Hasher;
         return d->Hasher;
     }
     StringHasherRef hasher;