Sketcher: Do not consider missing external geometry to be an error (… #1406
Annotations
2 errors and 36 warnings
Black (Python)
Process completed with exit code 1.
|
Cpplint
Process completed with exit code 1.
|
Black (Python):
src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py#L1
would reformat src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py
|
Pylint:
src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py#L1
Missing module docstring (missing-module-docstring)
|
Pylint:
src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py#L36
Missing function or method docstring (missing-function-docstring)
|
Pylint:
src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py#L67
Missing function or method docstring (missing-function-docstring)
|
Pylint:
src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py#L87
Missing function or method docstring (missing-function-docstring)
|
Pylint:
src/Mod/Sketcher/SketcherTests/TestSketchValidateCoincidents.py#L108
Missing function or method docstring (missing-function-docstring)
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L117
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L118
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L127
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L148
Missing space after , [whitespace/comma] [3]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L152
Missing space after , [whitespace/comma] [3]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L190
Should have a space between // and comment [whitespace/comments] [4]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L198
Should have a space between // and comment [whitespace/comments] [4]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L213
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L225
Missing space after , [whitespace/comma] [3]
|
Cpplint:
src/Mod/Sketcher/App/SketchObject.cpp#L226
Missing space after , [whitespace/comma] [3]
|
Clazy
NCollection_ListNode has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
Clazy
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clazy
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L216
10.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L240
statement should be inside braces [readability-braces-around-statements]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L242
statement should be inside braces [readability-braces-around-statements]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L244
statement should be inside braces [readability-braces-around-statements]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L246
statement should be inside braces [readability-braces-around-statements]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L255
statement should be inside braces [readability-braces-around-statements]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L285
do not use 'else' after 'return' [readability-else-after-return]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L295
5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L311
parameter name 's' is too short, expected at least 2 characters [readability-identifier-length]
|
Clang-tidy:
src/Mod/Sketcher/App/SketchObject.cpp#L312
statement should be inside braces [readability-braces-around-statements]
|
Loading